-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to list 9.6 properly #2665
Conversation
@DigitalBrains1 Does it make sense to backport this? (Please remove label if you don't agree.) |
🤷 |
It makes sense to backport because it adds CI stuff. The weird error is reproducable under Linux (that's a good thing). I can't get it to work. Applying the Nix workaround here:
does not help (it'll just say
I don't know what's up. And if the flags are even meant to be passed; I think it is running |
Fixed by haskell/cabal#9384, which is backported to |
As a work-around we can:
Very ugly, but it works. I have requested that GHC 9.8.2 comes with a version of Cabal containing the fix: https://gitlab.haskell.org/ghc/ghc/-/issues/24079#note_547902 |
The same work-around could be applied to our starter projects in order to get them to work with GHC 9.6 |
First, nice digging. Second, what a mess :(. I'll apply the three steps of the workaround. Edit: If we apply the version constraint, older GHCs fail to build. Cabal syntax refuses |
Okay, seems that we need to ask the Cabal maintainers to make a release in order for GHC to pick it up. |
I've asked on the Haskell Matrix. |
ff09ed2
to
3dc4dcf
Compare
3dc4dcf
to
cafa600
Compare
cafa600
to
177cb3d
Compare
fa2c3f1
to
7fdb5b6
Compare
Paths differ slightly across different GHC versions and Custom/Simple project setups.
Plus, test on 9.6 on Windows/macOS CI
7fdb5b6
to
0a771a6
Compare
Plus, test on 9.6 on Windows/macOS CI (cherry picked from commit cb331a8) # Conflicts: # .github/workflows/ci.yml # README.md
Plus, test on 9.6 on Windows/macOS CI
Plus, test on 9.6 on Windows/macOS CI Co-authored-by: Martijn Bastiaan <[email protected]>
This is the earliest release that includes the fix mentioned in clash-lang/clash-compiler#2665 (comment)
This is the earliest release that includes the fix mentioned in clash-lang/clash-compiler#2665 (comment)
Plus, test on 9.6 on Windows/macOS CI
Still TODO:
Write a changelog entry (see changelog/README.md)Check copyright notices are up to date in edited files