Fix Clash.Primitives.DSL.tuple on GHC-9.6 #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had the module name of tuples hardcoded to GHC.Tuple, but that changed in GHC-9.6. This would result in type mismatches in the generated VHDL. Fixes #2512
|
So the only thing in our test suite that triggered this bug was in a Vivado-specific test? I think we should write a regression test that doesn't rely on Vivado. |
hiddemoll
pushed a commit
that referenced
this pull request
Feb 1, 2024
It had the module name of tuples hardcoded to GHC.Tuple, but that changed in GHC-9.6. This would result in type mismatches in the generated VHDL. Fixes #2512
martijnbastiaan
pushed a commit
that referenced
this pull request
Feb 1, 2024
It had the module name of tuples hardcoded to GHC.Tuple, but that changed in GHC-9.6. This would result in type mismatches in the generated VHDL. Fixes #2512 (cherry picked from commit d6277c3) Co-authored-by: Leon Schoorl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had the module name of tuples hardcoded to GHC.Tuple, but that changed in GHC-9.6.
This would result in type mismatches in the generated VHDL.
Fixes #2512
Still TODO: