clash-cores: Fix xpmCdcHandshake #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
approved these changes
Nov 21, 2023
leonschoorl
force-pushed
the
fix-xpmCdcHandshake
branch
from
e668eaf to
d145c9f
Compare
martijnbastiaan
approved these changes
Nov 22, 2023
leonschoorl
force-pushed
the
fix-xpmCdcHandshake
branch
from
d145c9f to
6fbc2f1
Compare
* The HDL generated incorrectly set DEST_EXT_HSK=0, configuring it to generate acks automatically. While the exposed API and simulation model assumed external handshaking. * The dstStages and srcStages settings were flipped. This also updates the test so it can detect that first error. And improves the haddock a bit to clarify what the settings do and relate them to the XPM documentation.
leonschoorl
force-pushed
the
fix-xpmCdcHandshake
branch
from
6fbc2f1 to
a81c45b
Compare
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
* The HDL generated incorrectly set DEST_EXT_HSK=0, configuring it to generate acks automatically. While the exposed API and simulation model assumed external handshaking. * The dstStages and srcStages settings were flipped. This also updates the test so it can detect that first error. And improves the haddock a bit to clarify what the settings do and relate them to the XPM documentation. (cherry picked from commit 63b90ce)
martijnbastiaan
pushed a commit
that referenced
this pull request
Nov 23, 2023
* The HDL generated incorrectly set DEST_EXT_HSK=0, configuring it to generate acks automatically. While the exposed API and simulation model assumed external handshaking. * The dstStages and srcStages settings were flipped. This also updates the test so it can detect that first error. And improves the haddock a bit to clarify what the settings do and relate them to the XPM documentation. (cherry picked from commit 63b90ce) Co-authored-by: Leon Schoorl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improved the haddock a bit to clarify what the settings do and relate them to the XPM documentation.
Still TODO:
Write a changelog entry (see changelog/README.md), I've skipped this since there is no release or changelog for clash-cores