-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Aeson 2.2 #2578
Support Aeson 2.2 #2578
Conversation
bf9aca0
to
eaf0ac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Head branch was pushed to by a user without write access
eaf0ac0
to
093ce32
Compare
Fixed the syntax |
We need to help Stack find attoparsec-aeson, so I added that to stack.yaml |
46c589d
to
4c1e88d
Compare
Apparently, Stackage only has v2.1.0.0 |
cbad8b4
to
fcf2ce0
Compare
c846780
to
b2cb637
Compare
0871ef4
to
2d71558
Compare
Update nixpkgs to the latest unstable Co-authored-by: rowanG077 <[email protected]> Co-authored-by: Peter Lebbing <[email protected]>
2d71558
to
1f502af
Compare
Update nixpkgs to the latest unstable Co-authored-by: rowanG077 <[email protected]> Co-authored-by: Peter Lebbing <[email protected]> (cherry picked from commit 149885c) # Conflicts: # .ci/stack-8.10.yaml # .ci/stack-8.6.5.yaml # .ci/stack-8.8.4.yaml # .ci/stack-9.0.yaml # .ci/stack-9.2.yaml # flake.lock # flake.nix # nix/overlay-ghc902.nix # nix/overlay-ghc962.nix # stack.yaml
+ # We can't use newer than 1.12 here: we need singletons 3.x (due to the cabal
+ # file of `clash-testsuite`) but the changed `DConP` constructor in 1.13
+ # stops `singletons-th` from building.
+ doctest = prev.callHackage "doctest" "0.21.1" { }; What package is this comment refering to? |
@leon Copy pasted from the other and forgot to change the comment |
So th-desugar has a clash-compiler/nix/overlay-ghc962.nix Line 42 in 149885c
|
I needed to fix the other comment I promised to fix but didn't. I was going to put it in |
Comment is coming from the 9.0.2 overlay. https://github.com/clash-lang/clash-compiler/blob/master/nix/overlay-ghc902.nix#L29-L32C57 This is a good comment:
|
Co-authored-by: Vekhir <[email protected]> Co-authored-by: rowanG077 <[email protected]> Co-authored-by: Peter Lebbing <[email protected]>
Co-authored-by: Vekhir <[email protected]> Co-authored-by: Peter Lebbing <[email protected]>
Co-authored-by: Vekhir <[email protected]> Co-authored-by: Peter Lebbing <[email protected]>
Co-authored-by: Vekhir <[email protected]> Co-authored-by: Peter Lebbing <[email protected]>
@Vekhir, we've just released Clash 1.6.6 with this included! |
Thank you! |
The Data.Aeson.json functionality was moved to the
Data.Aeson.Parser
module withinattoparsec-aeson
. The new package replacesData.Aeson.Parser
foraeson
>= 2.2. Foraeson
<2.2,attoparsec-aeson
is an empty package, since the module exists within aeson.The solution in this PR supports both Aeson < 2.2 and Aeson >= 2.2.
Please release a new version on Hackage once this PR was merged, so the Arch packages can move to Aeson 2.2.