Move "Work-around for GHC 9.4 bug in ExpWithClashCF" #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the workaround added in c1ef28f from Exp.hs to ExpWithGhcCF.hs When I updated the CI image from 9.4.3 to 9.4.6 the ExpWithGhcCF test started to fail on the 9.4.6 nightly test with Other error: panic! (the 'impossible' happened) GHC version 9.4.6: refineFromInScope I've done some testing and I've found: Using ghc <= 9.4.4: The -fno-specialise workaround isn't need at all Using ghc 9.4.5 and 9.4.6: It needs the -fno-specialise workaround in ExpWithGhcCF, not in Exp. Otherwise the ExpWithGhcCF test fails, not the ExpWithClashCF like mentioned in the original commit msg.
leonschoorl
force-pushed
the
fix-ExpWith-9.4-workaround
branch
from
a3a8fd8 to
cfd7357
Compare
|
FYI ghc-9.4.7 still hits the same bug without the workaround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the workaround added in c1ef28f from Exp.hs to ExpWithGhcCF.hs
When I updated the CI image from 9.4.3 to 9.4.6 the ExpWithGhcCF test started to fail on the 9.4.6 nightly test with
I've done some testing and I've found:
Using ghc <= 9.4.4:
The -fno-specialise workaround isn't need at all
Using ghc 9.4.5 and 9.4.6:
It needs the
-fno-specialiseworkaround in ExpWithGhcCF, not in Exp.Otherwise the ExpWithGhcCF test fails,
not the ExpWithClashCF like mentioned in the original commit msg.
Still TODO: