Enable mmap crash workaround more widely #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're getting the mmap crash now very regularly on the gitlab runners
leonschoorl
force-pushed
the
enable-mmap-crash-workaround-more-widely
branch
from
72f06b4 to
52d85d7
Compare
martijnbastiaan
pushed a commit
to bittide/bittide-hardware
that referenced
this pull request
Aug 24, 2023
This works around multiple issues: * https://gitlab.haskell.org/ghc/ghc/-/issues/19421 * https://discourse.haskell.org/t/facing-mmap-4096-bytes-at-nil-cannot-allocate-memory-youre-not-alone/6259 Also see: * clash-lang/clash-compiler#2566 * clash-lang/clash-compiler#2444
martijnbastiaan
approved these changes
Aug 24, 2023
martijnbastiaan
pushed a commit
to bittide/bittide-hardware
that referenced
this pull request
Aug 24, 2023
This works around multiple issues: * https://gitlab.haskell.org/ghc/ghc/-/issues/19421 * https://discourse.haskell.org/t/facing-mmap-4096-bytes-at-nil-cannot-allocate-memory-youre-not-alone/6259 Also see: * clash-lang/clash-compiler#2566 * clash-lang/clash-compiler#2444
martijnbastiaan
added a commit
that referenced
this pull request
Aug 26, 2023
Enable mmap crash workaround more widely (copy #2566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately we seem to be triggering the mmap bug a lot easier and/or on more GHC versions.
For example in last nightly on master
This PR enable the workaround for all jobs with GHC < 9.2.8 and additionally updates all CI images to the latest GHC minor versions.
(Including 9.2.8 which should have fixed this issue)
Still TODO: