Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better RTS options for executables, makes benchmarks more sensible #2134

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

vmchale
Copy link
Contributor

@vmchale vmchale commented Mar 23, 2022

Stumbled upon this while working on #2074

This makes benchmarks run much faster. It brings them into agreement with the ghc-options set in the cabal.project file.

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

@vmchale vmchale requested a review from alex-mckenna March 23, 2022 15:12
Copy link
Contributor

@alex-mckenna alex-mckenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question: since we've added these here do we still need the ones in the cabal.project or can they be removed?

@vmchale
Copy link
Contributor Author

vmchale commented Mar 23, 2022

We still do! The ghc-options in our cabal.project are to control GHC when it's building our stuff, while the ghc-options passed in here are for the executable that is produced.

@vmchale vmchale requested a review from alex-mckenna March 23, 2022 15:26
Copy link
Contributor

@alex-mckenna alex-mckenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still do! The ghc-options in our cabal.project are to control GHC when it's building our stuff, while the ghc-options passed in here are for the executable that is produced.

In that case, have another green tick for the PR

@vmchale vmchale enabled auto-merge March 23, 2022 15:59
@leonschoorl
Copy link
Member

The commit message isn't very clear.
Just PR title would be a lot better IMHO.

@alex-mckenna alex-mckenna disabled auto-merge March 23, 2022 16:16
@alex-mckenna alex-mckenna enabled auto-merge (squash) March 23, 2022 16:16
@alex-mckenna
Copy link
Contributor

Changed to squash merge so it looks better in master

@vmchale
Copy link
Contributor Author

vmchale commented Mar 23, 2022

Ah, thanks!

@alex-mckenna alex-mckenna added this to the 1.6.3 milestone Mar 23, 2022
Use -with-rtsopts=-A128M for clash, clashi and benchmarks as the
larger allocation area improves performance
@alex-mckenna alex-mckenna force-pushed the larger-allocation-area branch from d7e2bf5 to 77e94fa Compare March 24, 2022 07:49
@alex-mckenna
Copy link
Contributor

Reworded commit message just to do something so GitHub actions would re-run

@martijnbastiaan
Copy link
Member

@vmchale Our commit message typically look like (but it's not a law or anything):

Added X to Y

Changed foo to include bar

Improved error handling in wibble

with a longer explanation in the commit description, possibly ending with Closes #11111 or Fixes #11111.

@alex-mckenna alex-mckenna merged commit 690fbea into master Mar 24, 2022
@alex-mckenna alex-mckenna deleted the larger-allocation-area branch March 24, 2022 08:46
mergify bot pushed a commit that referenced this pull request Mar 24, 2022
clashi larger allocation area

(cherry picked from commit 690fbea)
alex-mckenna pushed a commit that referenced this pull request Mar 24, 2022
clashi larger allocation area

(cherry picked from commit 690fbea)

Co-authored-by: Vanessa McHale <[email protected]>
@DigitalBrains1
Copy link
Member

Note that the squash merge reset the commit message to what it was before, ignoring the new message. An interesting interaction between a squash merge and a later force-push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants