-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better RTS options for executables, makes benchmarks more sensible #2134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One question: since we've added these here do we still need the ones in the cabal.project
or can they be removed?
We still do! The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still do! The ghc-options in our cabal.project are to control GHC when it's building our stuff, while the ghc-options passed in here are for the executable that is produced.
In that case, have another green tick for the PR
f4c9e9f
to
d7e2bf5
Compare
The commit message isn't very clear. |
Changed to squash merge so it looks better in |
Ah, thanks! |
Use -with-rtsopts=-A128M for clash, clashi and benchmarks as the larger allocation area improves performance
d7e2bf5
to
77e94fa
Compare
Reworded commit message just to do something so GitHub actions would re-run |
@vmchale Our commit message typically look like (but it's not a law or anything):
with a longer explanation in the commit description, possibly ending with |
clashi larger allocation area (cherry picked from commit 690fbea)
clashi larger allocation area (cherry picked from commit 690fbea) Co-authored-by: Vanessa McHale <[email protected]>
Note that the squash merge reset the commit message to what it was before, ignoring the new message. An interesting interaction between a squash merge and a later force-push. |
Stumbled upon this while working on #2074
This makes benchmarks run much faster. It brings them into agreement with the ghc-options set in the
cabal.project
file.Still TODO:
Write a changelog entry (see changelog/README.md)