Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Stack and Nix builds to GitLab CI #1705

Merged
merged 2 commits into from
Mar 13, 2021
Merged

Conversation

martijnbastiaan
Copy link
Member

No description provided.

@christiaanb
Copy link
Member

Will this still run the circle ci builds for external contributors?

@martijnbastiaan
Copy link
Member Author

martijnbastiaan commented Mar 12, 2021

"Normal" tests: yes, stack/nix: no. There's already a number of tests GitLab CI only (haddock, bindist tests), so I figured we should just treat Circle CI as the first line of defense and use its minutes sparingly. If we see any dependency changes in a PR, we should just clone and push to a local directory branch to run everything on GitLab.

I think we should spend a day on building a bot that does the clone+push for us on a, say, @clash-lang-builder run ci comment. I've talked to @leonschoorl and @alex-mckenna (independently, just during "coffee moments" so-to-speak) about this before. It should be pretty easy with GitHub Actions and/or probot:

Edit: Done

Clone branches from fork PRs by leaving a comment:

    @kloonbot run_ci <hash>
@martijnbastiaan martijnbastiaan marked this pull request as ready for review March 12, 2021 17:37
@martijnbastiaan
Copy link
Member Author

Going to go ahead and merge this so we can use it for #1708.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants