Update README.md bug #127
Merged
Update README.md bug #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change resetAllMocks to clearAllMocks Add clarity
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 27 27
Branches 5 5
=========================================
Hits 27 27 Continue to review full report at Codecov.
|
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current readme suggests using resetAllMocks between tests, but this actually breaks the mocks. The soltion is to use clearAllMocks which is already used within this project's own tests. I've updated the readme to suggest the correct function, and also make it more clear that
.clear()also needs to be used to fully reset state between tests.Original bug report: #83