Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid boolean conversion #9

Merged
merged 1 commit into from
Sep 24, 2013
Merged

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Sep 24, 2013

dir += '/' if not (dir.empty? or dir.end_with? '/')
is not the same as
dir += '/' if not dir.empty? or dir.end_with?('/')

530dac2

@clarete

@grosser
Copy link
Contributor Author

grosser commented Sep 24, 2013

please release a new patch version after merging that

@clarete
Copy link
Owner

clarete commented Sep 24, 2013

This is the kind of bug that I cause when I don't write enough tests :/

I'll definitely have to increase the test coverage of this tool soon. About the new release, there's something else I wanna push, but I'll definitely release a new version tonight.

Thank you again for your awesome work.

clarete added a commit that referenced this pull request Sep 24, 2013
fix invalid boolean conversion
@clarete clarete merged commit 8f263fd into clarete:master Sep 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants