Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sum stat for lambda detectors #369

Merged
merged 7 commits into from
Feb 18, 2022
Merged

use sum stat for lambda detectors #369

merged 7 commits into from
Feb 18, 2022

Conversation

xp-1000
Copy link
Contributor

@xp-1000 xp-1000 commented Jan 20, 2022

fix the stat to use sum instead of mean.

also add a note about the way lambda errors detector works which is not common.

@xp-1000 xp-1000 added bug Something isn't working detectors About nex or existing detectors labels Jan 20, 2022
@xp-1000 xp-1000 added this to the v1.13.0 milestone Jan 20, 2022
@xp-1000 xp-1000 requested a review from pdecat January 20, 2022 15:37
@xp-1000 xp-1000 requested a review from BzSpi as a code owner January 20, 2022 15:37
@xp-1000 xp-1000 self-assigned this Jan 20, 2022
@xp-1000 xp-1000 requested a review from pdecat January 21, 2022 15:46
@xp-1000 xp-1000 modified the milestones: v1.13.0, v1.14.0 Feb 17, 2022
pdecat
pdecat approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@pdecat pdecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xp-1000
Copy link
Contributor Author

xp-1000 commented Feb 18, 2022

Thanks @pdecat for the laborious digging/testing work.

@xp-1000 xp-1000 merged commit bd5599a into master Feb 18, 2022
@xp-1000 xp-1000 deleted the fix_lambda_stat branch February 18, 2022 16:17
@xp-1000 xp-1000 added the enhancement Enhancement of existing (templating or detectors) label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdecat pdecat pdecat approved these changes

@BzSpi BzSpi Awaiting requested review from BzSpi BzSpi is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin is a code owner

@Shr3ps Shr3ps Awaiting requested review from Shr3ps Shr3ps is a code owner

@tchernomax tchernomax Awaiting requested review from tchernomax tchernomax is a code owner

Assignees

@xp-1000 xp-1000

Labels
bug Something isn't working detectors About nex or existing detectors enhancement Enhancement of existing (templating or detectors)
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xp-1000 @pdecat