Fix deadlettered message queue detector #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidh-claranet
requested review from
BzSpi,
cvauvarin,
Shr3ps,
tchernomax and
xp-1000
as code owners
BzSpi
approved these changes
Dec 21, 2021
xp-1000
added
bug
|
@Davidh-claranet @BzSpi @Shr3ps the fix for dimension name should not be applied to other detectors too ? |
|
"EntityName" seems to only be used in the servicebus detector |
I spoke about other detectors in this module, it seems weird from azure to only change the dimension for one metric of service bus and not the others but I don't know azure 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the "entityname" field has been renamed to "EntityName". (The detctor was broken)
The major threshold has been changed to 0.