use right signalfx unit when available

modules/integration_aws-alb/conf/01-latency.yaml

@@ -5,7 +5,7 @@ id: latency
 transformation: true
 aggregation: true
 filtering: "filter('namespace', 'AWS/ApplicationELB')"
-value_unit: "s"
+value_unit: "Second"
 
 signals:
   signal:

modules/integration_aws-alb/detectors-gen.tf

@@ -35,8 +35,8 @@ resource "signalfx_detector" "latency" {
   tags                    = compact(concat(local.common_tags, local.tags, var.extra_tags))
 
   viz_options {
-    label        = "signal"
-    value_suffix = "s"
+    label      = "signal"
+    value_unit = "Second"
   }
 
   program_text = <<-EOF
@@ -47,7 +47,7 @@ resource "signalfx_detector" "latency" {
 EOF
 
   rule {
-    description           = "is too high > ${var.latency_threshold_critical}s"
+    description           = "is too high > ${var.latency_threshold_critical}Second"
     severity              = "Critical"
     detect_label          = "CRIT"
     disabled              = coalesce(var.latency_disabled_critical, var.latency_disabled, var.detectors_disabled)
@@ -59,7 +59,7 @@ EOF
   }
 
   rule {
-    description           = "is too high > ${var.latency_threshold_major}s"
+    description           = "is too high > ${var.latency_threshold_major}Second"
     severity              = "Major"
     detect_label          = "MAJOR"
     disabled              = coalesce(var.latency_disabled_major, var.latency_disabled, var.detectors_disabled)

modules/integration_aws-alb/variables-gen.tf

@@ -87,7 +87,7 @@ variable "latency_disabled_major" {
 }
 
 variable "latency_threshold_critical" {
-  description = "Critical threshold for latency detector in s"
+  description = "Critical threshold for latency detector in Second"
   type        = number
   default     = 1
 }
@@ -104,7 +104,7 @@ variable "latency_at_least_percentage_critical" {
   default     = 0.9
 }
 variable "latency_threshold_major" {
-  description = "Major threshold for latency detector in s"
+  description = "Major threshold for latency detector in Second"
   type        = number
   default     = 3
 }

modules/integration_aws-apigateway/conf/01-latency.yaml

@@ -4,7 +4,7 @@ name: latency
 transformation: true
 aggregation: true
 filtering: "filter('namespace', 'AWS/ApiGateway') and filter('stat', 'mean') and (not filter('Stage', '*')) and (not filter('Method', '*')) and (not filter('Resource', '*'))"
-value_unit: "ms"
+value_unit: "Millisecond"
 
 signals:
   signal:

modules/integration_aws-apigateway/detectors-gen.tf

@@ -6,8 +6,8 @@ resource "signalfx_detector" "latency" {
   tags                    = compact(concat(local.common_tags, local.tags, var.extra_tags))
 
   viz_options {
-    label        = "signal"
-    value_suffix = "ms"
+    label      = "signal"
+    value_unit = "Millisecond"
   }
 
   program_text = <<-EOF
@@ -18,7 +18,7 @@ resource "signalfx_detector" "latency" {
 EOF
 
   rule {
-    description           = "is too high > ${var.latency_threshold_critical}ms"
+    description           = "is too high > ${var.latency_threshold_critical}Millisecond"
     severity              = "Critical"
     detect_label          = "CRIT"
     disabled              = coalesce(var.latency_disabled_critical, var.latency_disabled, var.detectors_disabled)
@@ -30,7 +30,7 @@ EOF
   }
 
   rule {
-    description           = "is too high > ${var.latency_threshold_major}ms"
+    description           = "is too high > ${var.latency_threshold_major}Millisecond"
     severity              = "Major"
     detect_label          = "MAJOR"
     disabled              = coalesce(var.latency_disabled_major, var.latency_disabled, var.detectors_disabled)

modules/integration_aws-apigateway/variables-gen.tf

@@ -49,7 +49,7 @@ variable "latency_disabled_major" {
 }
 
 variable "latency_threshold_critical" {
-  description = "Critical threshold for latency detector in ms"
+  description = "Critical threshold for latency detector in Millisecond"
   type        = number
   default     = 1000
 }
@@ -66,7 +66,7 @@ variable "latency_at_least_percentage_critical" {
   default     = 0.9
 }
 variable "latency_threshold_major" {
-  description = "Major threshold for latency detector in ms"
+  description = "Major threshold for latency detector in Millisecond"
   type        = number
   default     = 3000
 }

modules/integration_aws-elasticache-redis/conf/03-replication-lag.yaml

@@ -4,7 +4,7 @@ name: replication lag
 transformation: true
 aggregation: true
 filtering: "filter('namespace', 'AWS/ElastiCache') and filter('stat', 'upper') and filter('CacheNodeId', '*')"
-value_unit: s
+value_unit: "Second"
 
 signals:
   signal:

modules/integration_aws-elasticache-redis/detectors-gen.tf

@@ -96,8 +96,8 @@ resource "signalfx_detector" "replication_lag" {
   tags                    = compact(concat(local.common_tags, local.tags, var.extra_tags))
 
   viz_options {
-    label        = "signal"
-    value_suffix = "s"
+    label      = "signal"
+    value_unit = "Second"
   }
 
   program_text = <<-EOF
@@ -108,7 +108,7 @@ resource "signalfx_detector" "replication_lag" {
 EOF
 
   rule {
-    description           = "is too high > ${var.replication_lag_threshold_critical}s"
+    description           = "is too high > ${var.replication_lag_threshold_critical}Second"
     severity              = "Critical"
     detect_label          = "CRIT"
     disabled              = coalesce(var.replication_lag_disabled_critical, var.replication_lag_disabled, var.detectors_disabled)
@@ -120,7 +120,7 @@ EOF
   }
 
   rule {
-    description           = "is too high > ${var.replication_lag_threshold_major}s"
+    description           = "is too high > ${var.replication_lag_threshold_major}Second"
     severity              = "Major"
     detect_label          = "MAJOR"
     disabled              = coalesce(var.replication_lag_disabled_major, var.replication_lag_disabled, var.detectors_disabled)

modules/integration_aws-elasticache-redis/variables-gen.tf

@@ -217,7 +217,7 @@ variable "replication_lag_disabled_major" {
 }
 
 variable "replication_lag_threshold_critical" {
-  description = "Critical threshold for replication_lag detector in s"
+  description = "Critical threshold for replication_lag detector in Second"
   type        = number
   default     = 180
 }
@@ -234,7 +234,7 @@ variable "replication_lag_at_least_percentage_critical" {
   default     = 1
 }
 variable "replication_lag_threshold_major" {
-  description = "Major threshold for replication_lag detector in s"
+  description = "Major threshold for replication_lag detector in Second"
   type        = number
   default     = 90
 }

modules/integration_aws-elb/conf/01-latency.yaml

@@ -4,7 +4,7 @@ name: backend latency
 transformation: true
 aggregation: true
 filtering: "filter('namespace', 'AWS/ApplicationELB')"
-value_unit: "s"
+value_unit: "Second"
 
 signals:
   signal:

modules/integration_aws-elb/detectors-gen.tf

@@ -35,8 +35,8 @@ resource "signalfx_detector" "backend_latency" {
   tags                    = compact(concat(local.common_tags, local.tags, var.extra_tags))
 
   viz_options {
-    label        = "signal"
-    value_suffix = "s"
+    label      = "signal"
+    value_unit = "Second"
   }
 
   program_text = <<-EOF
@@ -47,7 +47,7 @@ resource "signalfx_detector" "backend_latency" {
 EOF
 
   rule {
-    description           = "is too high > ${var.backend_latency_threshold_critical}s"
+    description           = "is too high > ${var.backend_latency_threshold_critical}Second"
     severity              = "Critical"
     detect_label          = "CRIT"
     disabled              = coalesce(var.backend_latency_disabled_critical, var.backend_latency_disabled, var.detectors_disabled)
@@ -59,7 +59,7 @@ EOF
   }
 
   rule {
-    description           = "is too high > ${var.backend_latency_threshold_major}s"
+    description           = "is too high > ${var.backend_latency_threshold_major}Second"
     severity              = "Major"
     detect_label          = "MAJOR"
     disabled              = coalesce(var.backend_latency_disabled_major, var.backend_latency_disabled, var.detectors_disabled)

modules/integration_aws-elb/variables-gen.tf

@@ -87,7 +87,7 @@ variable "backend_latency_disabled_major" {
 }
 
 variable "backend_latency_threshold_critical" {
-  description = "Critical threshold for backend_latency detector in s"
+  description = "Critical threshold for backend_latency detector in Second"
   type        = number
   default     = 1
 }
@@ -104,7 +104,7 @@ variable "backend_latency_at_least_percentage_critical" {
   default     = 0.9
 }
 variable "backend_latency_threshold_major" {
-  description = "Major threshold for backend_latency detector in s"
+  description = "Major threshold for backend_latency detector in Second"
   type        = number
   default     = 3
 }

modules/integration_azure-datafactory/conf/04-adf-integration-available-memory.yaml

@@ -2,19 +2,19 @@ module: "Azure DataFactory"
 name: "Available Memory"
 filtering: "filter('resource_type', 'Microsoft.DataFactory/factories') and filter('primary_aggregation_type', 'true')"
 aggregation: ".sum(by=['azure_resource_name', 'azure_resource_group_name', 'azure_region'])"
-value_unit: "MB"
+value_unit: "Mebibyte"
 transformation: ".min(over='15m')"
 signals:
   memory:
     metric: "IntegrationRuntimeAvailableMemory"
   signal:
     formula:
-      memory.scale(0.000000953674316) # Scale to MB unit
+      memory.scale(1/1024**2) # Scale to MiB unit
 rules:
   critical:
     threshold: 256
     comparator: "<"
   major:
     threshold: 512
     comparator: "<"
-    dependency: critical
+    dependency: critical

modules/integration_azure-datafactory/detectors-gen.tf

@@ -139,20 +139,20 @@ resource "signalfx_detector" "available_memory" {
   tags                    = compact(concat(local.common_tags, local.tags, var.extra_tags))
 
   viz_options {
-    label        = "signal"
-    value_suffix = "MB"
+    label      = "signal"
+    value_unit = "Mebibyte"
   }
 
   program_text = <<-EOF
     base_filtering = filter('resource_type', 'Microsoft.DataFactory/factories') and filter('primary_aggregation_type', 'true')
     memory = data('IntegrationRuntimeAvailableMemory', filter=base_filtering and ${module.filtering.signalflow})${var.available_memory_aggregation_function}${var.available_memory_transformation_function}
-    signal = memory.scale(0.000000953674316).publish('signal')
+    signal = memory.scale(1/1024**2).publish('signal')
     detect(when(signal < ${var.available_memory_threshold_critical}, lasting=%{if var.available_memory_lasting_duration_critical == null}None%{else}'${var.available_memory_lasting_duration_critical}'%{endif}, at_least=${var.available_memory_at_least_percentage_critical})).publish('CRIT')
     detect(when(signal < ${var.available_memory_threshold_major}, lasting=%{if var.available_memory_lasting_duration_major == null}None%{else}'${var.available_memory_lasting_duration_major}'%{endif}, at_least=${var.available_memory_at_least_percentage_major}) and (not when(signal < ${var.available_memory_threshold_critical}, lasting=%{if var.available_memory_lasting_duration_critical == null}None%{else}'${var.available_memory_lasting_duration_critical}'%{endif}, at_least=${var.available_memory_at_least_percentage_critical}))).publish('MAJOR')
 EOF
 
   rule {
-    description           = "is too low < ${var.available_memory_threshold_critical}MB"
+    description           = "is too low < ${var.available_memory_threshold_critical}Mebibyte"
     severity              = "Critical"
     detect_label          = "CRIT"
     disabled              = coalesce(var.available_memory_disabled_critical, var.available_memory_disabled, var.detectors_disabled)
@@ -164,7 +164,7 @@ EOF
   }
 
   rule {
-    description           = "is too low < ${var.available_memory_threshold_major}MB"
+    description           = "is too low < ${var.available_memory_threshold_major}Mebibyte"
     severity              = "Major"
     detect_label          = "MAJOR"
     disabled              = coalesce(var.available_memory_disabled_major, var.available_memory_disabled, var.detectors_disabled)

modules/integration_azure-datafactory/variables-gen.tf

@@ -301,7 +301,7 @@ variable "available_memory_disabled_major" {
 }
 
 variable "available_memory_threshold_critical" {
-  description = "Critical threshold for available_memory detector in MB"
+  description = "Critical threshold for available_memory detector in Mebibyte"
   type        = number
   default     = 256
 }
@@ -318,7 +318,7 @@ variable "available_memory_at_least_percentage_critical" {
   default     = 1
 }
 variable "available_memory_threshold_major" {
-  description = "Major threshold for available_memory detector in MB"
+  description = "Major threshold for available_memory detector in Mebibyte"
   type        = number
   default     = 512
 }

modules/integration_azure-storage-account-blob/conf/02-latency-e2e.yaml

@@ -4,7 +4,7 @@ filtering: "filter('resource_type', 'Microsoft.Storage/storageAccounts') and fil
 aggregation: ".sum(by=['azure_resource_name', 'azure_resource_group_name', 'azure_region'])"
 transformation: ".min(over='15m')"
 disabled: true
-value_unit: "s"
+value_unit: "Second"
 signals:
   latency:
     metric: "SuccessE2ELatency"

modules/integration_azure-storage-account-blob/detectors-gen.tf

@@ -52,8 +52,8 @@ resource "signalfx_detector" "latency_e2e" {
   tags                    = compact(concat(local.common_tags, local.tags, var.extra_tags))
 
   viz_options {
-    label        = "signal"
-    value_suffix = "s"
+    label      = "signal"
+    value_unit = "Second"
   }
 
   program_text = <<-EOF
@@ -65,7 +65,7 @@ resource "signalfx_detector" "latency_e2e" {
 EOF
 
   rule {
-    description           = "is too high > ${var.latency_e2e_threshold_critical}s"
+    description           = "is too high > ${var.latency_e2e_threshold_critical}Second"
     severity              = "Critical"
     detect_label          = "CRIT"
     disabled              = coalesce(var.latency_e2e_disabled_critical, var.latency_e2e_disabled, var.detectors_disabled)
@@ -77,7 +77,7 @@ EOF
   }
 
   rule {
-    description           = "is too high > ${var.latency_e2e_threshold_major}s"
+    description           = "is too high > ${var.latency_e2e_threshold_major}Second"
     severity              = "Major"
     detect_label          = "MAJOR"
     disabled              = coalesce(var.latency_e2e_disabled_major, var.latency_e2e_disabled, var.detectors_disabled)

modules/integration_azure-storage-account-blob/variables-gen.tf

@@ -133,7 +133,7 @@ variable "latency_e2e_disabled_major" {
 }
 
 variable "latency_e2e_threshold_critical" {
-  description = "Critical threshold for latency_e2e detector in s"
+  description = "Critical threshold for latency_e2e detector in Second"
   type        = number
   default     = 20
 }
@@ -150,7 +150,7 @@ variable "latency_e2e_at_least_percentage_critical" {
   default     = 1
 }
 variable "latency_e2e_threshold_major" {
-  description = "Major threshold for latency_e2e detector in s"
+  description = "Major threshold for latency_e2e detector in Second"
   type        = number
   default     = 10
 }

modules/integration_azure-storage-account/conf/02-capacity.yaml

@@ -3,13 +3,13 @@ name: "capacity"
 filtering: "filter('resource_type', 'Microsoft.Storage/storageAccounts') and filter('primary_aggregation_type', 'true')"
 aggregation: ".fill(None, duration='1d').sum(by=['azure_resource_name', 'azure_resource_group_name', 'azure_region'])"
 transformation: ".min(over='1d')"
-value_unit: PiB
+value_unit: "Pebibyte"
 signals:
   capacity:
     metric: "UsedCapacity"
   signal:
     formula:
-      capacity.scale(0.0000000000000008881784197001252) # Scale to PiB unit
+      capacity.scale(1/1024**5) # Scale to PiB unit
 rules:
   critical:
     threshold: 4.8