Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow load per cpu option to be optional #344

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Conversation

xp-1000
Copy link
Contributor

@xp-1000 xp-1000 commented Nov 15, 2021

the load monitor from smart agent allows to define perCPU option to automatically average load per cpu number.

before this was a mandatory config to set to use the load detector properly, it provides some advantages:

  • more straightforward to use
  • simpler signalflow
  • load metric without cpu num correlation is rarely useful
  • it needs only 1 metric instead of 2 (which ca have an impact on MTS plan)

that said, in some cases it could be useful to keep the original/raw information and make the division into the signalflow instead.
This PR adds an option to make this possible.

@xp-1000 xp-1000 self-assigned this Nov 15, 2021
@xp-1000 xp-1000 added detectors About nex or existing detectors enhancement Enhancement of existing (templating or detectors) labels Nov 15, 2021
@xp-1000 xp-1000 added this to the v1.11.0 milestone Nov 15, 2021
@xp-1000 xp-1000 marked this pull request as ready for review November 15, 2021 11:30
@xp-1000 xp-1000 changed the title test load per cpu allow load per cpu option to be optional Nov 15, 2021
@xp-1000 xp-1000 merged commit 69cf387 into master Nov 17, 2021
@xp-1000 xp-1000 deleted the load_per_cpu_optional branch November 17, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detectors About nex or existing detectors enhancement Enhancement of existing (templating or detectors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants