add systemd-timers module #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSenaud
requested review from
BzSpi,
cvauvarin,
Shr3ps and
tchernomax
as code owners
xp-1000
suggested changes
Nov 4, 2021
modules/smart-agent_systemd-timers/conf/01-timer-has-not-run-for.yaml
Outdated
Show resolved
Hide resolved
modules/smart-agent_systemd-timers/conf/01-timer-has-not-run-for.yaml
Outdated
Show resolved
Hide resolved
modules/smart-agent_systemd-timers/conf/02-timer-has-failed.yaml
Outdated
Show resolved
Hide resolved
modules/smart-agent_systemd-timers/conf/01-timer-has-not-run-for.yaml
Outdated
Show resolved
Hide resolved
modules/smart-agent_systemd-timers/conf/01-timer-has-not-run-for.yaml
Outdated
Show resolved
Hide resolved
modules/smart-agent_systemd-timers/conf/02-timer-has-failed.yaml
Outdated
Show resolved
Hide resolved
modules/smart-agent_systemd-timers/conf/02-timer-has-failed.yaml
Outdated
Show resolved
Hide resolved
xp-1000
suggested changes
Nov 9, 2021
There was a problem hiding this comment.
Can you add a note about the disabled detectors in "notes" section of the readme ?
Last question and we should be good: did you test this module in WITH the smart-agent_systemd-services deployed ? I am afraid there could be undesired conflicts or border cases between them. Indeed, as soon as you gather metrics for both: a "timer" service and a "normal" service, detectors of both module could apply different rules on same services no?
xp-1000
reviewed
Nov 9, 2021
NSenaud
force-pushed
the
feat-systemd-timers-detectors
branch
from
e614826
to
694a2bf
Compare
xp-1000
approved these changes
Nov 15, 2021
Co-authored-by: Quentin Manfroi <[email protected]>
NSenaud
force-pushed
the
feat-systemd-timers-detectors
branch
from
1d6e29a
to
e7c6c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New detectors to monitor Systemd Timers (and replace crons with better observability).