Fix Postgresql resource type name #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpoullain
requested review from
BzSpi,
cvauvarin,
Shr3ps,
tchernomax and
xp-1000
as code owners
If PR is not ready for merge so it should be a draft ;) |
xp-1000
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
When I merged I did not see the last change from * to ? which is subsequent to your last comment #299 (comment) and my approve
You are right, that was my bad. |
xp-1000
added
bug
ignacio-rivas
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Following up on this MR #299.
The regex with
Microsoft.DB?orPostgreSQL/serversdoesn't work on my project butMicrosoft.DB*orPostgreSQL/serversis working correctly.I don't think we were able to test with the
Microsoft.DB?orPostgreSQL/serversbefore it was merged.