Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Splunk changed Gigibyte to Gibibyte #474

Closed
haedri opened this issue Jun 16, 2023 · 1 comment · Fixed by #476
Closed

[BUG] Splunk changed Gigibyte to Gibibyte #474

haedri opened this issue Jun 16, 2023 · 1 comment · Fixed by #476
Assignees
Labels
bug Something isn't working detectors About nex or existing detectors
Milestone

Comments

@haedri
Copy link
Contributor

haedri commented Jun 16, 2023

What is the module?
integration_aws-rds-common/detectors-rds-common
integration_aws-efs/conf/01-used-space
integration_aws-elasticsearch/detectors-elasticsearch

What is the detector?
search : grep -R 'Gigibyte' *
$ grep -R 'Gigibyte' * | grep value_unit modules/integration_aws-rds-common/detectors-rds-common.tf: value_unit = "Gigibyte" modules/integration_aws-efs/detectors-gen.tf: value_unit = "Gigibyte" modules/integration_aws-efs/conf/01-used-space.yaml:value_unit: "Gigibyte" modules/integration_aws-elasticsearch/detectors-elasticsearch.tf: value_unit = "Gigibyte" modules/integration_aws-elasticsearch/detectors-elasticsearch.tf: value_unit = "Gigibyte" scripts/templates/detector.tf.j2: {%- if value_unit in ['Bit', 'Kilobit', 'Megabit', 'Gigabit', 'Terabit', 'Petabit', 'Exabit', 'Zettabit', 'Yottabit', 'Byte', 'Kibibyte','Mebibyte', 'Gigibyte', 'Tebibyte', 'Pebibyte', 'Exbibyte', 'Zebibyte', 'Yobibyte', 'Nanosecond', 'Microsecond', 'Millisecond', 'Second','Minute', 'Hour', 'Day', 'Week'] %}

Describe the bug
Splunk has corrected a typo on their part, Gibibyte were called Gigibyte before, so now Gigibyte does not work
This breaks the detector graphs, nothing else, it's juste a visual glitch

@haedri haedri added bug Something isn't working detectors About nex or existing detectors labels Jun 16, 2023
@haedri haedri self-assigned this Jun 16, 2023
@haedri haedri added this to the v1.25.0 milestone Jun 16, 2023
@haedri
Copy link
Contributor Author

haedri commented Jun 16, 2023

Bug opened on the module side : splunk-terraform/terraform-provider-signalfx#433
We can't update ours for now

@haedri haedri linked a pull request Jul 3, 2023 that will close this issue
haedri added a commit that referenced this issue Jul 3, 2023
* fix - [BUG] Splunk changed Gigibyte to Gibibyte #474

* fix - [BUG] Splunk changed Gigibyte to Gibibyte #474

---------

Co-authored-by: Jean-Baptiste Simillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working detectors About nex or existing detectors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant