Skip to content

Commit

Permalink
SNAT ports: add resource name in mean (#559)
Browse files Browse the repository at this point in the history
* SNAT ports: add resource name in mean

* run make

* conform to usaual format

---------

Co-authored-by: Quentin GIBERT <[email protected]>
Co-authored-by: Jean-Baptiste Simillon <[email protected]>
  • Loading branch information
3 people authored Jun 18, 2024
1 parent 4f1ea67 commit 54d5504
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion modules/integration_azure-firewall/conf/01-snat.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module: Azure firewall
name: "SNAT Port Utilization"

transformation: true
aggregation: ".mean(by=['protocol'])"
aggregation: ".mean(by=['protocol', 'azure_resource_name', 'azure_resource_group_name', 'azure_region'])"

filtering: "filter('resource_type', 'Microsoft.Network/azureFirewalls') and filter('primary_aggregation_type', 'true')"

Expand Down
2 changes: 1 addition & 1 deletion modules/integration_azure-firewall/variables-gen.tf
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ variable "snat_port_utilization_notifications" {
variable "snat_port_utilization_aggregation_function" {
description = "Aggregation function and group by for snat_port_utilization detector (i.e. \".mean(by=['host'])\")"
type = string
default = ".mean(by=['protocol'])"
default = ".mean(by=['protocol', 'azure_resource_name', 'azure_resource_group_name', 'azure_region'])"
}

variable "snat_port_utilization_transformation_function" {
Expand Down

0 comments on commit 54d5504

Please sign in to comment.