Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter to current timestamp #44

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

paulocesarjr
Copy link
Contributor

@paulocesarjr paulocesarjr commented Mar 20, 2024

Summary

This MR implements a new getter currentTimestamp originated by the PLAYBACK_FRAGMENT_CHANGED event. This makes it possible to access the current timestamp of the fragment reproduced by the playback.

Changes

  • hls.js: add currentTimestamp getter;
  • hls.test.js: add testes to currentTimestamp getter.

@paulocesarjr paulocesarjr changed the title Add getter to current fragment Draft: Add getter to current fragment Mar 20, 2024
@paulocesarjr paulocesarjr changed the title Draft: Add getter to current fragment Add getter to current fragment Mar 20, 2024
@paulocesarjr paulocesarjr marked this pull request as draft March 20, 2024 20:48
@paulocesarjr paulocesarjr force-pushed the feature/fragment-getter branch from 7c2aabd to 706dc7e Compare March 20, 2024 21:12
@paulocesarjr paulocesarjr marked this pull request as ready for review March 21, 2024 11:33
@paulocesarjr paulocesarjr self-assigned this Mar 21, 2024
@paulocesarjr paulocesarjr marked this pull request as draft March 21, 2024 13:36
@paulocesarjr paulocesarjr force-pushed the feature/fragment-getter branch 2 times, most recently from c17284a to 6a4182e Compare March 21, 2024 14:15
@paulocesarjr paulocesarjr force-pushed the feature/fragment-getter branch from 6a4182e to 58fdf51 Compare March 21, 2024 14:22
@paulocesarjr paulocesarjr changed the title Add getter to current fragment Add getter to current timestamp Mar 21, 2024
@paulocesarjr paulocesarjr marked this pull request as ready for review March 21, 2024 14:26
@pedrochamberlain pedrochamberlain merged commit de07d83 into master Mar 21, 2024
1 check passed
@paulocesarjr paulocesarjr deleted the feature/fragment-getter branch March 21, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants