Fix core Tests #91
Merged
Fix core Tests #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaofelipe
requested review from
pedrochamberlain,
felipecesr,
jhonatangcavalcanti and
paulocesarjr
jhonatangcavalcanti
requested changes
Nov 29, 2022
The isFullScreen only returns true if there is a valid fullscreenElement or activePlaybackEl
jhonatangcavalcanti
force-pushed
the
fix/core-tests
branch
from
94df912 to
be0c466
Compare
jhonatangcavalcanti
approved these changes
Dec 7, 2022
felipecesr
approved these changes
Dec 13, 2022
pedrochamberlain
approved these changes
Dec 13, 2022
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes tests for Core. #86
How to test
Just run the tests normally.