-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core - Make reset CSS configurable #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopaulovieira
requested review from
leandromoreira,
towerz and
jhonatangcavalcanti
November 10, 2020 19:29
leandromoreira
approved these changes
Nov 12, 2020
pedrochamberlain
approved these changes
Nov 13, 2020
@@ -0,0 +1,5 @@ | |||
@import 'reset'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
jhonatangcavalcanti
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates the possibility to don't use
nested-reset
CSS mixin when the new optionresetStyle
is configured with thefalse
value. One default value forresetStyle
option is created to maintain the current behavior.Also, the style injection is changed to allow the new feature.
The path pattern to access modules is updated to use the
src
alias on all files where is necessary to update the style injection.Changes
rollup.config.js
:rollup-plugin-postcss
to enable inject style on the element itself instad thehead
pageplayer.js
:true
) forresetStyle
optioncore/public/style.scss
:nested-reset
CSS mixincore/public/optional.scss
:nested-reset
CSS mixincore.js
:optional.scss
accordingly theresetStyle
valuecore.js
/container.js
/html5_video.js
/html_img.js
/no_op.js
:head
page;How to test
head
tag on the page;core
element on the page;CoreStyle
andOptionalStyle
);resetStyle
option with thefalse
value;CoreStyle
);A picture tells a thousand words
Before this PR
After this PR
With
resetStyle = true
With
resetStyle = false