Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
defaultOptions.playback
being overwritten when the received options on Clappr init have theplayback
options too. The expected behavior is the merge between those two options.This PR applies the expected behavior using the Zepto
$.extend()
method with the option for a deep merge approach.Changes
$.extend
call;How to test
player.options.playback
on developr tools console tab;recycleVideo: true
andcontrols: true
.A picture tells a thousand words
Before this PR
After this PR