Fix leaks #108
Merged
Fix leaks #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielfurtado
approved these changes
Aug 28, 2023
For each call to load method, the core was appending new style tags, creating unnecessary multiple DOM elements
The contextmenu event was not removed. This was causing a leak of event listeners since a new listener was added but not removed for each player load call.
jhonatangcavalcanti
force-pushed
the
feature/fix-leaks
branch
from
349d4c8 to
c40fc5a
Compare
pedrochamberlain
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a leak of the
contextmenuevent handler on the video tag and prevents adding multiplestyletag children to thecorewhen changing the video with theloadmethod.Changes
core.js:html5_video.js:contextmenuon destroyHow to test
loadon the same sample media many timesstyletags and only onecontextmenulistenerImages
Before this PR
After this PR