This repository has been archived by the owner on May 11, 2020. It is now read-only.
Adding pub to the parse functions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also attach |
|
Added the attribute, I couldn't find a good description of when to use this one so I'm unsure if I did it in the best way... Let me know and I can fix this. |
|
@CreepySkeleton what do you think about this? looks good to me |
|
Yeah, this is great, but #23 has it done already 😕 |
|
Thanks. Closing it |
|
This is not fixed by #23 so reopening it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue clap-rs/clap#1575 when the struct to parse is in a separate file by changing the parse functions to public.