api(Arg): add default_value_os
#941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add related tests, and reframe `default_value` in terms of `defualt_value_os`.
|
Changes Unknown when pulling d5ef895 on nuew:default_value_os into ** on kbknapp:master**. |
|
I read through the Issues and the code makes sense to me. Though I am not nearly to be a maintainer, so you mind as well ignore my 👍 - 😉 |
|
I have to say; I like you @mention-bot !! 😂 |
|
Awesome, thanks for tackling this! @homu r+ |
|
📌 Commit d5ef895 has been approved by |
homu
added a commit
that referenced
this pull request
May 5, 2017
api(Arg): add `default_value_os` Also add related tests, and reframe `default_value` in terms of `defualt_value_os`. This resolves #849. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kbknapp/clap-rs/941) <!-- Reviewable:end -->
|
⚡ Test exempted - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add related tests, and reframe
default_valuein terms ofdefualt_value_os.This resolves #849.
This change is