Implement name setter on App; fixes #908 #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuperFluffy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp, @tormol and @hexjelly to be potential reviewers. |
This was referenced Mar 21, 2017
|
@homu r+ Thanks! |
|
📌 Commit feb3616 has been approved by |
homu
added a commit
that referenced
this pull request
Mar 22, 2017
Implement name setter on App; fixes #908 Probably should have done that immediately before opening an issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kbknapp/clap-rs/910) <!-- Reviewable:end -->
|
⚡ Test exempted - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably should have done that immediately before opening an issue.
This change is