feat(Completions): one can generate a basic fish completions script at compile time #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The team is excited to review your changes, and you should hear from @sru (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
☔ The latest upstream changes (presumably #570) made this pull request unmergeable. Please resolve the merge conflicts. |
|
🎉 🎉 @wdv4758h Can you rebase onto the latest master? Then we can merge this awesomeness! Thanks! 👍 |
…t compile time The following completion would happen (using example 17_yaml.rs): ``` $ prog <tab> help subcmd ``` ``` $ prog -<tab><tab> --help -h (Prints help information) --max-vals (you can only supply a max of 3 values for me!) --min-vals (you must supply at least two values to satisfy me) --mode (shows an option with specific values) --mult-vals (demos an option which has two named values) --option -o (example option argument from yaml) --version -V (Prints version information) -F (demo flag argument) ``` ``` $ prog --<tab><tab> --help -h (Prints help information) --max-vals (you can only supply a max of 3 values for me!) --min-vals (you must supply at least two values to satisfy me) --mode (shows an option with specific values) --mult-vals (demos an option which has two named values) --option -o (example option argument from yaml) --version -V (Prints version information) ``` ``` $ prog --mode <tab> emacs (shows an option with specific values) vi (shows an option with specific values) ``` ``` $ prog subcmd -<tab> --help -h (Prints help information) -B (example subcommand option) --version -V (Prints version information) ``` ``` $ prog subcmd --<tab> --help (Prints help information) --version (Prints version information) ``` Close clap-rs#578
wdv4758h
force-pushed
the
fish-completion
branch
from
e662f2c to
1979d2f
Compare
|
@kbknapp Done. Please review again 😃 |
|
Looks great! Thanks again 👍 @homu r+ |
|
📌 Commit 1979d2f has been approved by |
homu
added a commit
that referenced
this pull request
Jul 28, 2016
feat(Completions): one can generate a basic fish completions script at compile time As I've mentioned in #578 , I've made my first working [fish](https://github.com/fish-shell/fish-shell) completion. 😄 Things may work like this :    
homu
added a commit
that referenced
this pull request
Jul 28, 2016
feat(Completions): one can generate a basic fish completions script at compile time As I've mentioned in #578 , I've made my first working [fish](https://github.com/fish-shell/fish-shell) completion. 😄 Things may work like this :    
|
☀️ Test successful - status |
|
👀 Test was successful, but fast-forwarding failed: 422 Required status check "continuous-integration/appveyor/pr" is expected |
homu
added a commit
that referenced
this pull request
Jul 28, 2016
Wdv4758h fish completion merge of #579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've mentioned in #578 , I've made my first working fish completion. 😄
Things may work like this :