Add support for completing --flag value<TAB>, -fbar<TAB>, -f=bar<TAB> and -f bar<TAB>
#5533
Conversation
shannmu
force-pushed
the
cargo_completions
branch
from
097482c to
a9f4b5a
Compare
|
The current code hasn't been tested a lot. I've just done some quick tests using the dynamic program from the tests. |
.vscode/launch.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Please revert this. I don't want to get into the business of having the config files for every users editor in my repos
There was a problem hiding this comment.
(in git, you can configure a user-wide ignore and place these here for yourself)
| /// Complete the given command | ||
| /// NOTE: borrow the idea from Parser.rs::ParseState to record the state during completion.s | ||
| #[derive(Debug, PartialEq, Eq, Clone)] | ||
| enum CompletionState { |
There was a problem hiding this comment.
Let's call this ParseState to be more specific (and match clap's parser)
| /// Complete the given command | ||
| /// NOTE: borrow the idea from Parser.rs::ParseState to record the state during completion.s | ||
| #[derive(Debug, PartialEq, Eq, Clone)] | ||
| enum CompletionState { |
There was a problem hiding this comment.
style: we generally put implementation details for logic after the logic (so move this after complete)
|
I need to split this PR into smaller PRs for easier discussion and review. How should I handle the situation where one resulting PR might be based on another PR? |
shannmu
force-pushed
the
cargo_completions
branch
from
54581a0 to
4f03598
Compare
Either hold off on the follow up PRs or put them up, note the dependency, and rebase once the other PR is merged. |
Related issues:
In this PR, I modified some logic in the complete function:
CompletionStateto record the current parsing state during completion parsing. When completion is triggered withtarget_cursorequal tocursor, the completion function will be chosen based on theCompletionState.completefunction for arg over subcommand, optional long flag, escape, negative number, optional short flag, stdio, and empty.complete_argforarg, with the same priority as above.There are some TODOs in this PR that I will implement later, including:
args_conflicts_with_subcommandssubcommand_precedence_over_argmulticall