Make FromStr::Err not need to be a Send+Sync+'static
#5149
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand, standard rust library does not require error::Error to be a Send+Sync+'static, and (for example)
structopt
does not. Butclap
require. Thus, the library turns out to be incompatible with most parsing libraries that returnBox<dyn Error>
as an error.This commit proposes to relax this requirement. This makes the library more backward-compatible with
structopt
. This will allow errors to be thrown from libraries that return errors, that notSend
orSync
, for examplessсanf
:A test+example of using such errors has also been added.
I know that a year ago there was a discussion about how the return Ok() result could also be !send+!sync+!clone (#3833), and I tried to do that - but it turned out that it required a lot of work.