Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix typos in README.md #490

Merged
merged 1 commit into from
May 3, 2016
Merged

chore: Fix typos in README.md #490

merged 1 commit into from
May 3, 2016

Conversation

nvzqz
Copy link
Contributor

@nvzqz nvzqz commented Apr 21, 2016

No description provided.

@yo-bot
Copy link

yo-bot commented Apr 21, 2016

Thanks for the pull request, and welcome! The team is excited to review your changes, and you should hear from @Vinatorul (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 87.375% when pulling e6cb687 on nvzqz:master into 94b33c5 on kbknapp:master.

@kbknapp
Copy link
Member

kbknapp commented May 3, 2016

@nvzqz I apologize for taking so long, I've been out of town the past two weeks. Looks great, and thanks for the contribution!! 👍

@homu r+

@homu
Copy link
Contributor

homu commented May 3, 2016

📌 Commit e6cb687 has been approved by kbknapp

homu added a commit that referenced this pull request May 3, 2016
@homu
Auto merge of #490 - nvzqz:master, r=kbknapp
297dac5 
chore: Fix typos in README.md
homu added a commit that referenced this pull request May 3, 2016
@homu
Auto merge of #490 - nvzqz:master, r=kbknapp
634f3c9 
chore: Fix typos in README.md
@homu
Copy link
Contributor

homu commented May 3, 2016

⌛ Testing commit e6cb687 with merge 634f3c9...

@homu
Copy link
Contributor

homu commented May 3, 2016

☀️ Test successful - status

@homu
Copy link
Contributor

homu commented May 3, 2016

👀 Test was successful, but fast-forwarding failed: 422 Required status check "coverage/coveralls" is pending

@kbknapp
Copy link
Member

kbknapp commented May 3, 2016

Manually merging...

@kbknapp kbknapp merged commit 84381b5 into clap-rs:master May 3, 2016
epage added a commit to epage/clap that referenced this pull request Oct 6, 2021
@epage
fix(derive): Fix the problem where the build fails due to the ambiguo…
51c723a 
…us type of `map`

> This PR closes clap-rs#490. Please refer to clap-rs#490 for the detail of the problem. Let me know if you want to make `convert_type` a function.

This is a port of TeXitoi/structopt#491

This is part of clap-rs#2809
@epage epage mentioned this pull request Oct 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vinatorul Vinatorul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nvzqz @yo-bot @coveralls @kbknapp @homu @Vinatorul