Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): Update iterator sizes as we go #4875

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

epage
Copy link
Member

@epage epage commented May 2, 2023

Maybe it was just me, but I didn't realize that the length had to be updated as we went but it can cause panics with a bad message.

Fixes #4870

Maybe it was just me, but I didn't realize that the length had to be
updated as we went but it can cause panics with a bad message.

Fixes clap-rs#4870
@epage epage merged commit 7b40f43 into clap-rs:master May 2, 2023
@epage epage deleted the panic branch May 2, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clap::parser::Values enters unreachable code if used inside zip and reversed
1 participant