feat(parser): Make customizeing flags easier #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `TypedValueParser` will generally make it easier to reuse value parsers, this was particularly written for flags. Besides having a concrete API to document, an advantage over `fn(&str) -> Result<bool, E>` value parsers is you get all of the benefits of the existing value parsers for environment variable parsing.
2 tasks
epage
added a commit
to epage/clap
that referenced
this pull request
Sep 12, 2022
This is a partial backport of clap-rs#4095. This was written to allow mapping bools to other types but this will be useful for people using `PossibleValue` with non-string types to upgrade to value parsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
TypedValueParserwill generally make it easier to reuse valueparsers, this was particularly written for flags. Besides having a
concrete API to document, an advantage over
fn(&str) -> Result<bool, E>value parsers is you get all of the benefits of the existing value
parsers for environment variable parsing.