fix(derive): Don't emit warnings #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this is coming from `update_from_arg_matches` where we do a ladder of `if __clap_arg_matches.is_present(...)` that clippy wants to be `else if`s. While for human edited code, that does clarify intent, for machine generated code that is rarely read, its a pain to do, so silencing it. Unfortunately, it isn't in a group we can overall silence. Fixes clap-rs#3017
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this is coming from
update_from_arg_matcheswhere we do aladder of
if __clap_arg_matches.is_present(...)that clippy wants tobe
else ifs. While for human edited code, that does clarify intent,for machine generated code that is rarely read, its a pain to do, so
silencing it.
Unfortunately, it isn't in a group we can overall silence.
Fixes #3017