Fix handling of number_of_values when displaying arg
#2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldm0
changed the title
num_of_values when displaying argnumber_of_values when displaying arg
epage
reviewed
Aug 15, 2021
| }; | ||
| write!(f, "{}", sep)?; | ||
| } | ||
| if self.is_set(ArgSettings::TakesValue) || self.is_positional() { |
There was a problem hiding this comment.
Positionals now always TakesValue, so this can be simplified
There was a problem hiding this comment.
This is or rather than and. I guess it can't simplified.
There was a problem hiding this comment.
Too late, but I think it can. If positionals always have TakesValue set then you just need to check TakesValue.
positional = true
takes_value = true
if takes_value || positional = true
if takes_value = true
positional = false
takes_value = true
if takes_value || positional = true
if takes_value = true
positional = false
takes_value = false
if takes_value || positional = false
if takes_value = false
positional = true
takes_value = false
# Impossible
There was a problem hiding this comment.
shrug we all overlook things like that.
epage
reviewed
Aug 15, 2021
pksunkara
reviewed
Aug 17, 2021
src/build/arg/mod.rs
Outdated
| } else { | ||
| write!(f, "<{}>", self.name)?; | ||
| /// Write the values such as <name1> <name2> | ||
| pub fn display_arg_val<F, T, E>(arg: &Arg, mut write: F) -> Result<(), E> |
There was a problem hiding this comment.
Suggested change
| pub fn display_arg_val<F, T, E>(arg: &Arg, mut write: F) -> Result<(), E> | |
| pub(crate) fn display_arg_val<F, T, E>(arg: &Arg, mut write: F) -> Result<(), E> |
pksunkara
approved these changes
Aug 17, 2021
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1571