fix!: value_name/value_names should not append #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
force-pushed
the
value_name
branch
3 times, most recently
from
36df30f to
ee5a125
Compare
pksunkara
reviewed
Aug 13, 2021
Instead they should behave like `default_value`/`default_values`. In implementingt this, I didn't see any reason to be using a `VecMap`. In fact, this helped simplify the code / make intent clearer. With this, we are also able to simplify the derive macro work from clap-rs#2633. Fixes clap-rs#2634 BREAKING CHANGE: `value_name`/`value_names` always overwrite, rather than append. We expect the impact to be minimal.
pksunkara
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead they should behave like
default_value/default_values.In implementingt this, I didn't see any reason to be using a
VecMap.In fact, this helped simplify the code / make intent clearer.
With this, we are also able to simplify the derive macro work from #2633.
Fixes #2634
BREAKING CHANGE:
value_name/value_namesalways overwrite, ratherthan append. We expect the impact to be minimal.