fix(exit): Be consistent in exit code #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
force-pushed
the
exit
branch
2 times, most recently
from
580c347 to
8b84c05
Compare
PR clap-rs#1637 switched clap to report `64` on errors and then clap-rs#1653 switch it to `2`, but both missed a case. This also documents the reason why inline since I had to go and dig through the history to re-discover the motivation.
pksunkara
approved these changes
Jul 25, 2021
epage
added a commit
to epage/clap
that referenced
this pull request
Oct 16, 2021
I missed a case in clap-rs#2604. This will help people discover the documentation describing why we chose the code we did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1637 switched clap to report
64on errors and then #1653 switch itto
2, but both missed a case. This also documents the reason why inlinesince I had to go and dig through the history to re-discover the
motivation.