Make App::about accept Cow #2504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
reviewed
May 28, 2021
|
This pull request is not meant to be merged. The example changes make no sense to be in the tree and are just there to show what was not possible beforehand. This is only one API adjusted, I suppose others remain with similar problems. It's meant to show the ergonomics of the API, as you asked for.
I don't know. I haven't done an analysis. But then, it's a cold method being adjusted, right? |
|
The ergonomics are definitely more complicated now. But the API is more useful now. I was wondering what the performance would say.
This line is not cold and is part of the parsing logic. |
|
What's the performance measurement setup you folks use? |
|
We use criterion, and we have benches setup already. You don't need to test the dynamic string. Just provide a static string to |
|
Seems as if there were a couple of regressions detected: |
|
Some of it might just be margin of error. |
miDeb
reviewed
Jun 18, 2021
| } else { | ||
| self.parser.app.about | ||
| self.parser.app.about.as_ref().map(|a| a.as_ref()) |
There was a problem hiding this comment.
Quick suggestion: This could be written simpler:
Suggested change
| self.parser.app.about.as_ref().map(|a| a.as_ref()) | |
| self.parser.app.about.as_deref() |
(applies to other occurences of .as_ref().map(|a| a.as_ref()) as well, they can all be .as_deref())
|
Closing this. Thanks for the work @d-e-s-o. |
This was referenced Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft only. See #2150