Refactor: Builder pattern methods receiving str array parameters to instead take ref iterators #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structure implementing str ref iteration
pksunkara
reviewed
Mar 13, 2021
…e implementing str ref iteration
…cture implementing str ref iteration
…tructure implementing ref iteration
…cture implementing ref iteration
|
In general I get a little nervous when adding generic arguments being that the number one and two complaints about clap are it's binary size and compile times...both of which are increased by generic arguments. However in a case like this, the methods are small enough that the addition should be negligible for a pretty clear ergonomic win. |
epage
added a commit
to epage/clap
that referenced
this pull request
Oct 12, 2021
This replaces the most common uses of `&[]` with `IntoIterator`. This is based on clap-rs#2414. Unlike that, this stays consistent with using `Into<&'help str>`. There are some remaining functions not converted over, like defaults and requires. BREAKING CHANGE: Instances like `aliases(&[])` need to switch to `aliases([])`.
|
Recreated this in #2857 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, builder pattern Arg methods which allow inserting multiple values,
receive parameters of type
&[&'... str]. This can be an inconvenience to work with, for example -When attempting to pass to those methods data that isn't manually hard-coded.
This PR allows utilizing these methods as usual but also allows more freedom to receive other types.
TODO
ArgEnumprocedural macro).