Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demangle interlinking flags #2362

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Demangle interlinking flags #2362

merged 4 commits into from
Mar 9, 2021

Conversation

ldm0
Copy link
Member

@ldm0 ldm0 commented Feb 24, 2021

Fixes #2233 .

@ldm0 ldm0 requested a review from pksunkara February 24, 2021 15:47
@ldm0
Copy link
Member Author

ldm0 commented Feb 27, 2021

Any opinion? As this is a big breaking change we must make, I suggest we merge it in the beta.4.

@pksunkara
Copy link
Member

Yeah, I am reviewing.

pksunkara
pksunkara requested changes Mar 9, 2021
View reviewed changes
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Just minor comments and we can merge this. Sorry for the delay, I was travelling.

src/build/arg/debug_asserts.rs Show resolved Hide resolved
src/build/arg/mod.rs Outdated Show resolved Hide resolved
src/build/arg/debug_asserts.rs Outdated Show resolved Hide resolved
src/build/arg/debug_asserts.rs Outdated Show resolved Hide resolved
src/build/arg/debug_asserts.rs Show resolved Hide resolved
@ldm0 ldm0 requested a review from pksunkara March 9, 2021 14:10
@pksunkara
Copy link
Member

Feel free to merge once the CI passes since I approved it. Now, let's finish off #2360

@ldm0
Copy link
Member Author

ldm0 commented Mar 9, 2021

Feel free to merge once the CI passes since I approved it. Now, let's finish off #2360

But :-P:
image

@pksunkara
Copy link
Member

Try calling bors r+

@ldm0
Copy link
Member Author

ldm0 commented Mar 9, 2021

bors r+

bors bot added a commit that referenced this pull request Mar 9, 2021
@bors @ldm0
Merge #2362
f992ddc 
2362: Demangle interlinking flags r=ldm0 a=ldm0



Co-authored-by: ldm0 <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 9, 2021

Build failed:

@ldm0
Copy link
Member Author

ldm0 commented Mar 9, 2021

bors retry

bors bot added a commit that referenced this pull request Mar 9, 2021
@bors @ldm0
Merge #2362
0632c37 
2362: Demangle interlinking flags r=ldm0 a=ldm0



Co-authored-by: ldm0 <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 9, 2021

Build failed:

@pksunkara pksunkara merged commit d53f192 into clap-rs:master Mar 9, 2021
@ldm0 ldm0 mentioned this pull request Mar 9, 2021
Merged
@ldm0 ldm0 deleted the demangle branch March 9, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple set to false fails
2 participants
@ldm0 @pksunkara