Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant imports and clone (found by clippy) #1760

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

matthiaskrgr
Copy link
Contributor

No description provided.

@pksunkara
Copy link
Member

Umm, they are not redundant imports. We have several features. You probably didn't run clippy with --all-features.

@matthiaskrgr
Copy link
Contributor Author

The imports are redundant because in the code because the full import paths are already specified.
If we use &yaml_rust::yaml::Hash, there is no need to import yaml_rust.

https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports

cargo check --all-targets --all-features passes locally (I also cargo checked all the features one by one manually, no failures)

@pksunkara pksunkara self-requested a review March 25, 2020 11:55
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor issue

src/output/fmt.rs Outdated Show resolved Hide resolved
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 25, 2020

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link
Contributor

bors bot commented Mar 25, 2020

Build succeeded

@bors bors bot merged commit d8434ec into clap-rs:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants