Revert "Upgrading yaml-rust to 0.4.2" #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1415
Reasoning
I merged this PR yesterday, not fully aware of how the public API would be changed.
Committing to this change would require us to release a
clap 3.0for it which seems very unreasonable.After merging the idea was to re-work the function signatures to preserve the
clap 2.0API while bumping to a new yaml version. This doesn't seem to be possible though becausearg_yaml.as_hash()now hands out ownership of a tree, instead of just borrowing it.The only reasonable choice at this time is to revert this PR.
Alternatives
This is not to say that
clapshould depend on code that has known security vulnerabilities, small as they might be.Because of this I feel it would be more appropriate to try to fix the recursion issue on the
0.3branch ofyaml_rustinstead of bumping to a breaking change.Apologies for the carfuffle!
cc/ @gedigi