Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 dev #1241

Merged
merged 3 commits into from
Apr 4, 2018
Merged

V3 dev #1241

merged 3 commits into from
Apr 4, 2018

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Apr 4, 2018

Implements #1235 and #1238 on v3


This change is Reviewable

kbknapp and others added 3 commits April 3, 2018 20:00
Add logic to filter based on hidden long/short.

There is still an issue with the logic in parser.rs use_long_help. This
causes invalid evaluation of whether to show/hide based on long or short help
Complete check for use_long_help, add tests
Fixes the implementation of the hiding of arguments form the short or long help on v3
@mention-bot
Copy link

@kbknapp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@kbknapp kbknapp merged commit 4df65d8 into v3-master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants