Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 dev #1228

Merged
merged 6 commits into from
Mar 21, 2018
Merged

V3 dev #1228

merged 6 commits into from
Mar 21, 2018

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Mar 21, 2018 •
edited
Loading

This change is Reviewable

kbknapp added 6 commits March 21, 2018 15:05
@kbknapp
depr(App): adds plural settings and unset_settings to deprecations
f236596
@kbknapp
refactor: changes the signature of App::args to be more generic
fba268a
@kbknapp
api(App): adds App::get_matches_mut for Lib Blitz style naming consit…
e5d44ea 
…ency
@kbknapp
api(App): adds App::mut_arg to be able to mutate Args after they've b…
60c634b 
…een added to an App

Once can now mutate an Arg instance after it's already been added to an App struct.
This is helpful when you wish to add all the args in an non-verbose way, such as
via the usage strings, but wish for a handful to have settings which arne't posible
in the usage string definitions.
@kbknapp
api(App): adds App::unset_global_setting to be able to unset a globa …
2264b25 
…setting
@kbknapp
tests: fixes failing tests from new API additions
8f1c0cf
@mention-bot
Copy link

@kbknapp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@kbknapp kbknapp merged commit c9159d3 into v3-master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbknapp @mention-bot