Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in the 3.1.11 release #3648

Closed
2 tasks done
weiznich opened this issue Apr 22, 2022 · 3 comments
Closed
2 tasks done

Breaking change in the 3.1.11 release #3648

weiznich opened this issue Apr 22, 2022 · 3 comments
Labels
C-bug Category: Updating dependencies

Comments

@weiznich
Copy link

Please complete the following tasks

Rust Version

rustc 1.54.0 (a178d0322 2021-07-26)

Clap Version

3.1.11

Minimal reproducible code

Sorry, cannot provide that right now. I've observing failing tests due to a clap update in diesel_cli. See here for a failing test run.

Steps to reproduce the bug with the above code

git clone https://github.com/diesel-rs/diesel
cd diesel/diesel_cli
DATABASE_URL=/tmp/test.db cargo test --features "sqlite sqlite" --no-default-features # watch the tests failing
cargo update -p clap:3.1.11 --precise=3.1.10
DATABASE_URL=/tmp/test.db cargo test --features "sqlite sqlite" --no-default-features # all tests are passing now

Actual Behaviour

Test fail

Expected Behaviour

Test should not fail

Additional Context

I will update the this issue with more details as soon as I found the actual reason which part of the diesel cli interface is affected by this change.

Debug Output

No response

@weiznich weiznich added the C-bug Category: Updating dependencies label Apr 22, 2022
@weiznich
Copy link
Author

This was introduced by 6a9a5d0. Diesel tests pass before that commit, but fail afterwards.

weiznich added a commit to weiznich/clap that referenced this issue Apr 22, 2022
This commit fixes mixing up the stdout/stderr streams in claps output
module
weiznich added a commit to weiznich/clap that referenced this issue Apr 22, 2022
This commit fixes mixing up the stdout/stderr streams in claps output
module
@weiznich
Copy link
Author

Closed by #3646

@epage
Copy link
Member

epage commented Apr 22, 2022

v3.1.12 s released (I was worried about this very case and triple checked for it!)

epage added a commit to epage/clap that referenced this issue Apr 22, 2022
This is to prevent clap-rs#3648 from happening again
epage added a commit to epage/clap that referenced this issue Apr 22, 2022
This is to prevent clap-rs#3648 from happening again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Updating dependencies
Projects
None yet
Development

No branches or pull requests

2 participants