refactor(error): Move bad-escape suggestion to general suggestion

clap-rs · Oct 13, 2022 · 813060e · 813060e
1 parent 7417c75
commit 813060e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/src/error/format.rs b/src/error/format.rs
@@ -101,17 +101,6 @@ impl ErrorFormatter for RichFormatter {
                 styled.good(invalid_arg);
                 styled.none("'");
             }
-
-            let trailing_arg = error.get(ContextKind::TrailingArg);
-            if trailing_arg == Some(&ContextValue::Bool(true)) {
-                styled.none("\n\n");
-                styled.none(TAB);
-                styled.none("If you tried to supply '");
-                styled.warning(invalid_arg);
-                styled.none("' as a subcommand, remove the '");
-                styled.warning("--");
-                styled.none("' before it.");
-            }
         }
 
         let suggestions = error.get(ContextKind::Suggested);

diff --git a/src/error/mod.rs b/src/error/mod.rs
@@ -690,9 +690,19 @@ impl<F: ErrorFormatter> Error<F> {
 
         #[cfg(feature = "error-context")]
         {
+            let mut styled_suggestion = StyledStr::new();
+            styled_suggestion.none("If you tried to supply '");
+            styled_suggestion.warning(&arg);
+            styled_suggestion.none("' as a subcommand, remove the '");
+            styled_suggestion.warning("--");
+            styled_suggestion.none("' before it.");
+
             err = err.extend_context_unchecked([
                 (ContextKind::InvalidArg, ContextValue::String(arg)),
-                (ContextKind::TrailingArg, ContextValue::Bool(true)),
+                (
+                    ContextKind::Suggested,
+                    ContextValue::StyledStrs(vec![styled_suggestion]),
+                ),
             ]);
             if let Some(usage) = usage {
                 err = err