Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Gate log crate behind feature flag #126

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Nov 17, 2024

  • Add log feature flag (enabled by default)
  • Move log specific code to log module
  • Move top level re-exports of log types to log module

BREAKING CHANGE: The log crate is now an optional dependency, enabled by
default. The log::Level and log::LevelFilter types are now
re-exported from the log module rather than the crate root. If you
were using these types directly, you will need to update your imports.

-use clap_verbosity_flag::{Level, LevelFilter};
+use clap_verbosity_flag::log::{Level, LevelFilter};

@coveralls
Copy link

coveralls commented Nov 17, 2024

Pull Request Test Coverage Report for Build 11903102822

Details

  • 20 of 36 (55.56%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.2%) to 51.087%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/log.rs 16 32 50.0%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 8 51.67%
Totals Coverage Status
Change from base Build 11897580108: 2.2%
Covered Lines: 47
Relevant Lines: 92

💛 - Coveralls

src/log.rs Outdated Show resolved Hide resolved
src/log.rs Show resolved Hide resolved
- Add log feature flag (enabled by default)
- Move log specific code to `log` module
- Move top level re-exports of log types to `log` module

BREAKING CHANGE: The log crate is now an optional dependency, enabled by
default. The `log::Level` and `log::LevelFilter` types are now
re-exported from the `log` module rather than the crate root. If you
were using these types directly, you will need to update your imports.

```diff
-use clap_verbosity_flag::{Level, LevelFilter};
+use clap_verbosity_flag::log::{Level, LevelFilter};
```
@epage epage merged commit ed05b10 into clap-rs:master Nov 20, 2024
17 checks passed
@joshka joshka deleted the jm/log-optional branch November 27, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants