Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Use VerbosityFilter instead of log::Level #125

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Nov 17, 2024

This makes it possible to later support the tracing crate directly
without needing to convert between log::Level and tracing::Level.

BREAKING CHANGE: The LogLevel trait now uses VerbosityFilter instead
of Option<log::Level>. This change should be source-compatible with
most existing application code using this crate, but breaks any code
that implements the LogLevel trait.

This makes it possible to later support the `tracing` crate directly
without needing to convert between `log::Level` and `tracing::Level`.

BREAKING CHANGE: The `LogLevel` trait now uses `VerbosityFilter` instead
of `Option<log::Level>`. This change should be source-compatible with
most existing application code using this crate, but breaks any code
that implements the `LogLevel` trait.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11875028263

Details

  • 38 of 72 (52.78%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-10.3%) to 48.913%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 38 72 52.78%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 3 48.91%
Totals Coverage Status
Change from base Build 11866209379: -10.3%
Covered Lines: 45
Relevant Lines: 92

💛 - Coveralls

@epage epage merged commit ffffbe5 into clap-rs:master Nov 18, 2024
15 checks passed
@joshka joshka deleted the jm/verbosity-filter branch November 18, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants