Autoselect #29
Autoselect #29
Conversation
tim-pugh
requested review from
tim-pugh,
connorkuehl,
jcantrell,
jeffreytakahashi,
nforbus and
Nixoncole
| }; | ||
|
|
||
| class Randstruct : public RecordFieldReorganizer { | ||
| public: | ||
| //Automatic Structure selection |
There was a problem hiding this comment.
Since this method is public, we should use Doxygen syntax and give a better description here.
/// Determines if the Record can be safely and easily randomized based on certain criteria (see implementation).
This was discussed in the meeting after you left but they're working on it Wed |
There was a problem hiding this comment.
@Jafosterja @jcantrell I opened a new issue to add the command line argument
This will be checked at our entry point, so we don't need to check this here.
connorkuehl
requested review from
connorkuehl
and removed request for
connorkuehl
|
PR looks feature-complete. The Argument is used like:
|
| @@ -1751,6 +1751,9 @@ def freroll_loops : Flag<["-"], "freroll-loops">, Group<f_Group>, | |||
| HelpText<"Turn on loop reroller">, Flags<[CC1Option]>; | |||
| def fno_reroll_loops : Flag<["-"], "fno-reroll-loops">, Group<f_Group>, | |||
| HelpText<"Turn off loop reroller">; | |||
| def randstruct_auto : Flag<["-"], "randstruct-auto">, | |||
| HelpText<"Enable automatic structure selection for field randomization; " | |||
| "disabled with no_randomize_layout">, Flags<[CC1Option]>; | |||
There was a problem hiding this comment.
Should we notate that this is disabled with the "attribute no_randomize_layout"?
There was a problem hiding this comment.
I think that'd be wise. Certainly more clear than much of what exists already.
| for (auto f : D->fields()){ | ||
| //If an element of the structure does not have a | ||
| //function type is not a function pointer | ||
| if(f->getFunctionType() == nullptr){ return false; } |
Added basic implantation of automatic structure selection. This implementation will auto select structures full of entirely function pointers.
Closes #5
Closes #32