Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with pretokenized parameter #32

Closed
marcverhagen opened this issue Jun 10, 2024 · 0 comments · Fixed by #33
Closed

Errors with pretokenized parameter #32

marcverhagen opened this issue Jun 10, 2024 · 0 comments · Fixed by #33
Labels
🐛B Something isn't working

Comments

@marcverhagen
Copy link
Contributor

Bug Description

There are errors in the pre-tokenization code and as the code is now spaCy will actually generate all tokens even if they are in another view. The issues are here:

app-spacy-wrapper/app.py

Lines 53 to 54 in ce95ecc

if 'pretokenizd' in parameters and parameters['pretokenized']:
for view in mmif_obj.get_Views_for_document(doc.id):

At least these typos need to be fixed.

Reproduction steps

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

No response

Log output

No response

Screenshots

No response

Additional context

No response

@marcverhagen marcverhagen added the 🐛B Something isn't working label Jun 10, 2024
@clams-bot clams-bot added this to apps Jun 10, 2024
@github-project-automation github-project-automation bot moved this to Todo in apps Jun 10, 2024
@marcverhagen marcverhagen mentioned this issue Jun 10, 2024
@keighrim keighrim linked a pull request Jun 10, 2024 that will close this issue
marcverhagen added a commit that referenced this issue Jun 11, 2024
Bumping Python SDK version, bug fixes and documentation updates

- Updated to clams-python 1.2.2
- Fixed token length (issue #30)
- Fixed problems with the pretokenized parameter (issue #32) 
- Various documentation fixes.
@github-project-automation github-project-automation bot moved this from Todo to Done in apps Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛B Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant