Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LoadProgressBar position #28

Closed
wants to merge 1 commit into from
Closed

Fix LoadProgressBar position #28

wants to merge 1 commit into from

Conversation

nikgt
Copy link
Contributor

@nikgt nikgt commented Jan 19, 2018

Description

Fix buffering bar position issue

Copy link
Owner

@cladera cladera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nikgt, I tested it my self and it works like charm.

I've got only one request, could you add a simple test just to make sure we don't break player's buffered method?
I'm aware the project has a poor coverage right now but I plan to improve that for the next release.

Again, thank you so much for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants